[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gdb-patches
Subject:    Re: Two observations using GDB 13 snapshot
From:       Eli Zaretskii via Gdb-patches <gdb-patches () sourceware ! org>
Date:       2022-12-30 14:31:31
Message-ID: 835ydt6jzw.fsf () gnu ! org
[Download RAW message or body]

> Date: Thu, 29 Dec 2022 15:22:31 -0500
> Cc: gdb-patches@sourceware.org, luis.machado@arm.com
> From: Simon Marchi <simark@simark.ca>
> 
> 
> It looks like we spend a lot of time sorting the vector of index
> entries.  We spend a lot of time in tolower.

Why do we need to use tolower in sorting here? is the sorting order
case-insensitive or something?

> Googling a bit, it looks
> like tolower can be slow on Windows when a locale (other than "C") is
> used:
> 
> https://stackoverflow.com/questions/36686381/windows-c-runtime-toupper-slow-when-locale-set
> https://bugs.php.net/bug.php?id=45265

I couldn't see any numbers there about the performance of tolower
itself, i.e. how many ms per call does it take on Windows vs glibc.
But if someone can show a patch to try to eliminate the calls to
tolower, I can try and see if it affects the processing time in this
scenario.

Thanks.
[prev in list] [next in list] [prev in thread] [next in thread]