[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gdb-patches
Subject:    Re: [PATCH v3 05/14] update gdb.base/info-program.exp to not fail with clang
From:       Andrew Burgess via Gdb-patches <gdb-patches () sourceware ! org>
Date:       2022-06-30 14:45:35
Message-ID: 874k02cir4.fsf () redhat ! com
[Download RAW message or body]

Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> writes:

> The updated test specifically mentions that it doesn't care where the
> program stops, however it was still testing for something.  With this
> correction, the test works even if the compiler doesn't add epilogue
> information to functions.

Considering Pedro's feedback on an earlier patch about "epilogue
information" being potentially confusing, maybe this should be replaced
with something like:

  "... if the compiler doesn't emit line table entries for the function
  epilogue."

Or something similar.

This patch is OK with that change.

Thanks,
Andrew


> ---
> 
> No change in v3.
> 
> No change in v2.
> 
> ---
> gdb/testsuite/gdb.base/info-program.exp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gdb/testsuite/gdb.base/info-program.exp \
> b/gdb/testsuite/gdb.base/info-program.exp index facc13efa2f..f652cfbf426 100644
> --- a/gdb/testsuite/gdb.base/info-program.exp
> +++ b/gdb/testsuite/gdb.base/info-program.exp
> @@ -28,7 +28,7 @@ gdb_test "info program" "Program stopped at $hex\.\r\nIt stopped \
> at breakpoint $ 
> # We don't really care where this step lands, so long as it gets
> # the inferior pushed off the breakpoint it's currently on...
> -gdb_test "next" "$decimal\t.*" "step before info program"
> +gdb_test "next" ".*" "step before info program"
> 
> gdb_test "info program" "Program stopped at $hex\.\r\nIt stopped after being \
> stepped\.\r\nType \"info stack\" or \"info registers\" for more information\." \ \
>                 "info program after next"
> -- 
> 2.31.1


[prev in list] [next in list] [prev in thread] [next in thread]