[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gdb-patches
Subject:    Re: [PATCH 4/4] gdb: change regcache list to be a map
From:       Simon Marchi <simark () simark ! ca>
Date:       2020-07-30 18:17:33
Message-ID: 0ae62fca-0e23-a7bd-fd12-d75e55d2bbb0 () simark ! ca
[Download RAW message or body]

Just a note, I think your implementation of get_thread_arch_aspace_regcache could
be simplified by using the top map's operator[].  When we look up a regcache, we'll
want to create it if it doesn't exist, which means that if the ptid_regcache_map
doesn't exist for a given target, we'll want to create it.

I'll do that change, but I wanted to tell you in case you see a problem with it.

Simon
[prev in list] [next in list] [prev in thread] [next in thread]