[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gdb-patches
Subject:    [PATCH] Don't use the mutex for each symbol_set_names call
From:       gdb-patches () sourceware ! org (Christian Biesinger via gdb-patches)
Date:       2019-09-30 21:45:00
Message-ID: CAPTJ0XH-Mu-nedz5tm3hW4=+GzqRJydNyR76B=Kih3+bOp3-Bg () mail ! gmail ! com
[Download RAW message or body]

Hi Tom,

On Mon, Sep 30, 2019 at 9:18 AM Tom Tromey <tom@tromey.com> wrote:
> 
> > > > > > "Christian" == Christian Biesinger via gdb-patches \
> > > > > > <gdb-patches@sourceware.org> writes:
> 
> Christian> Also available, rebased to trunk, on
> Christian> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=shortlog;h=refs/heads/users/cbiesinger/parallel-minsyms-mutex
>  Christian> ]
> 
> I didn't read the patch yet, but this weekend I did rebase my branch and
> fixed most of the review issues.  So, you may want to consider rebasing
> on that.

Looking at your current patch version, I noticed this line in parallel-for.h:
+  if (n_threads > 1 && 2 * n_threads >= n_elements)

I am fairly sure this should be <= in the threads comparison,
otherwise you only use threads if there are few elements, which is the
opposite of what is desired (perhaps a merge error?)

Christian


[prev in list] [next in list] [prev in thread] [next in thread]