[prev in list] [next in list] [prev in thread] [next in thread]
List: gdb-patches
Subject: [PATCH 1/2] linux-nat: Remove unnecessary xstrdup
From: simon.marchi () ericsson ! com (Simon Marchi)
Date: 2017-12-31 15:00:00
Message-ID: 1514732385-5506-1-git-send-email-simon.marchi () ericsson ! com
[Download RAW message or body]
I think this xstrdup is not useful. We can pass ex.message directly to
throw_error instead.
gdb/ChangeLog:
* linux-nat.c (linux_nat_attach): Remove xstrdup.
---
gdb/linux-nat.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c
index b8f3108..1d1d6d3 100644
--- a/gdb/linux-nat.c
+++ b/gdb/linux-nat.c
@@ -1224,10 +1224,7 @@ linux_nat_attach (struct target_ops *ops, const char *args, int from_tty)
{
pid_t pid = parse_pid_to_attach (args);
struct buffer buffer;
- char *message, *buffer_s;
-
- message = xstrdup (ex.message);
- make_cleanup (xfree, message);
+ char *buffer_s;
buffer_init (&buffer);
linux_ptrace_attach_fail_reason (pid, &buffer);
@@ -1237,9 +1234,9 @@ linux_nat_attach (struct target_ops *ops, const char *args, int from_tty)
make_cleanup (xfree, buffer_s);
if (*buffer_s != '\0')
- throw_error (ex.error, "warning: %s\n%s", buffer_s, message);
+ throw_error (ex.error, "warning: %s\n%s", buffer_s, ex.message);
else
- throw_error (ex.error, "%s", message);
+ throw_error (ex.error, "%s", ex.message);
}
END_CATCH
--
2.7.4
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic