[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gdb-patches
Subject:    [PATCH v3.2 2/5] DWARF-5: .debug_names index producer
From:       simon.marchi () ericsson ! com (Simon Marchi)
Date:       2017-12-31 3:52:00
Message-ID: 83456520-cc06-25a5-de6e-9ae841341b45 () ericsson ! com
[Download RAW message or body]

On 2017-12-08 06:51 PM, Pedro Alves wrote:
>> +static bool
>> +check_dwarf64_offsets ()
>> +{
>> +  for (int i = 0; i < dwarf2_per_objfile->n_comp_units; ++i)
>> +    {
>> +      const dwarf2_per_cu_data &per_cu (*dwarf2_per_objfile->all_comp_units[i]);
>> +
>> +      if (to_underlying (per_cu.sect_off) >= (static_cast<uint64_t> (1) << 32))
>> +	return true;
>> +    }
>> +  for (int i = 0; i < dwarf2_per_objfile->n_type_units; ++i)
>> +    {
>> +      const signatured_type &sigtype (*dwarf2_per_objfile->all_type_units[i]);
>> +      const dwarf2_per_cu_data &per_cu (sigtype.per_cu);
>> +
>> +      if (to_underlying (per_cu.sect_off) >= (static_cast<uint64_t> (1) << 32))
>> +	return true;
> These look like always return false, since per_cu.sect_off is 32-bit?
> I've left it as is, but it doesn't look right to me.  Seems like
> that makes all the 64-bit support dead as is.

Clang indeed complains about this tautology.

I made a patch that makes sect_offset 64-bits, if you want to take a look:
https://sourceware.org/ml/gdb-patches/2017-12/msg00530.html

Simon


[prev in list] [next in list] [prev in thread] [next in thread]