[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gdb-patches
Subject:    [PATCH v4 4/4] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p
From:       simon.marchi () polymtl ! ca (Simon Marchi)
Date:       2017-12-27 0:30:00
Message-ID: 7efaac98-a656-1453-5ecb-f3cf5184b7b7 () polymtl ! ca
[Download RAW message or body]

On 2017-12-26 08:48 AM, Stafford Horne wrote:
> tdesc_register_in_reggroup_p in now able to handle arbitrary
> groups. This is useful when groups are created while the
> target descriptor file is received from the remote.
> 
> This can be the case of a soft core target processor where
> registers/groups can change.
> 
> gdb/ChangeLog:
> 
> yyyy-mm-dd  Franck Jullien  <franck.jullien@gmail.com>
> 	    Stafford Horne  <shorne@gmail.com>
> 
> 	* target-descriptions.c (tdesc_register_in_reggroup_p): Support
> 	arbitrary strings.

Please mention tdesc_use_registers in the ChangeLog.  I also usually mention
changes to comments, such as the change to tdesc_reg::group's comment.

LGTM with that fixed.

Thanks!

Simon


[prev in list] [next in list] [prev in thread] [next in thread]