[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gdb-patches
Subject:    [PATCH v2 2/3] Display names of remote threads
From:       simon.marchi () ericsson ! com (Simon Marchi)
Date:       2015-11-27 15:16:00
Message-ID: 565873D3.3040002 () ericsson ! com
[Download RAW message or body]

On 15-11-27 09:37 AM, Yao Qi wrote:
> Simon Marchi <simon.marchi@ericsson.com> writes:
> 
> > +  attr = xml_find_attribute (attributes, "name");
> > +  item.name = attr != NULL ? xstrdup (attr->value) : NULL;
> > +
> 
> This breaks the C++ build,
> 
> /home/yao/SourceCode/gnu/gdb/git/gdb/remote.c: In function ?void \
> start_thread(gdb_xml_parser*, const gdb_xml_element*, void*, \
>                 VEC_gdb_xml_value_s*)?:
> /home/yao/SourceCode/gnu/gdb/git/gdb/remote.c:2975:50: error: invalid conversion \
> from ?void*? to ?const char*? [-fpermissive] item.name = attr != NULL ? xstrdup \
> (attr->value) : NULL; ^
> In file included from \
> /home/yao/SourceCode/gnu/gdb/git/gdb/common/common-defs.h:64:0, from \
> /home/yao/SourceCode/gnu/gdb/git/gdb/defs.h:28, from \
>                 /home/yao/SourceCode/gnu/gdb/git/gdb/remote.c:22:
> /home/yao/SourceCode/gnu/gdb/git/gdb/../include/libiberty.h:323:14: note: \
> initializing argument 1 of ?char* xstrdup(const char*)? extern char *xstrdup (const \
> char *) ATTRIBUTE_MALLOC ATTRIBUTE_RETURNS_NONNULL; 
> and I think you've already received the mail from buildbot.
> http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cxx-build-m64/builds/1413
> 


Ahh, silly me, I didn't try to build with C++.

Strange, I didn't receive anything from Buildbot.

I just pushed this to fix it:


> From e19616610d7327664f99215a69cb326682742dc3 Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@ericsson.com>
Date: Fri, 27 Nov 2015 10:14:42 -0500
Subject: [PATCH] remote.c: Add missing cast
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Fixes in C++:

/home/emaisin/src/binutils-gdb/gdb/remote.c: In function ?void \
                start_thread(gdb_xml_parser*, const gdb_xml_element*, void*, \
                VEC_gdb_xml_value_s*)?:
/home/emaisin/src/binutils-gdb/gdb/remote.c:2975:59: error: invalid conversion from \
?void*? to ?const char*? [-fpermissive]  item.name = attr != NULL ? (char *) xstrdup \
(attr->value) : NULL;  ^
In file included from /home/emaisin/src/binutils-gdb/gdb/common/common-defs.h:64:0,
                 from /home/emaisin/src/binutils-gdb/gdb/defs.h:28,
                 from /home/emaisin/src/binutils-gdb/gdb/remote.c:22:
/home/emaisin/src/binutils-gdb/gdb/../include/libiberty.h:323:14: error:   \
initializing argument 1 of ?char* xstrdup(const char*)? [-fpermissive]  extern char \
*xstrdup (const char *) ATTRIBUTE_MALLOC ATTRIBUTE_RETURNS_NONNULL;  ^
make[2]: *** [remote.o] Error 1

gdb/ChangeLog:

	* remote.c (start_thread): Add cast.
---
 gdb/ChangeLog | 4 ++++
 gdb/remote.c  | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 54642e1..fd84223 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2015-11-27  Simon Marchi  <simon.marchi@ericsson.com>
+
+	* remote.c (start_thread): Add cast.
+
 2015-11-27  Yao Qi  <yao.qi@linaro.org>

 	* nat/aarch64-linux-hw-point.c (aarch64_dr_state_remove_one_point):
diff --git a/gdb/remote.c b/gdb/remote.c
index a80e548..90be8b6 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -2972,7 +2972,7 @@ start_thread (struct gdb_xml_parser *parser,
     item.core = -1;

   attr = xml_find_attribute (attributes, "name");
-  item.name = attr != NULL ? xstrdup (attr->value) : NULL;
+  item.name = attr != NULL ? xstrdup ((const char *) attr->value) : NULL;

   item.extra = 0;

-- 
2.5.1


[prev in list] [next in list] [prev in thread] [next in thread]