[prev in list] [next in list] [prev in thread] [next in thread]
List: gdb-patches
Subject: [PATCH 3/3] Replace TUI's select_frame hook (PR tui/13378)
From: patrick () parcs ! ath ! cx (Patrick Palka)
Date: 2015-06-30 17:49:00
Message-ID: CA+C-WL-VbNmwKAdbaN2fQWHupgsTeKKy=F51zN_HbvV=CJYTFg () mail ! gmail ! com
[Download RAW message or body]
On Tue, Jun 30, 2015 at 1:32 PM, Pedro Alves <palves@redhat.com> wrote:
> On 06/30/2015 06:10 PM, Patrick Palka wrote:
>
>>> Hmm, what about when the user changes registers with "print $rax = 1" etc.?
>>> Do we end up with stale contents?
>>
>> Apparently not, thanks to our deprecated_register_changed_hook called
>> from value_assign. So many hooks!
>
> Phew! And luckily there's an equivalent registers_changed observer
> we could use instead too.
How convenient.
>
> Patch is OK, just please mention tui_register_changed_hook ...
>
>> +/* Observer for the before_prompt notification. */
>> +
>> +static void
>> +tui_before_prompt (const char *current_gdb_prompt)
>> +{
>> + /* This refresh is intended to catch changes to the selected frame following
>> + a call to "up", "down" or "frame". As such we don't necessarily want to
>> + refresh registers here as they could not have changed. Registers will be
>> + refreshed after a normal stop. */
>
> ... here too.
>
> Awesome. Glad that this is finally fixed.
Me too. The results are quite nice. TUI is silky smooth.
>
> Thanks,
> Pedro Alves
>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic