[prev in list] [next in list] [prev in thread] [next in thread]
List: gdb-patches
Subject: [PATCH] Let gdbserver doesn't tell GDB it support target-side breakpoint conditions and commands if
From: palves () redhat ! com (Pedro Alves)
Date: 2013-11-29 16:05:00
Message-ID: 5298AE7C.6020607 () redhat ! com
[Download RAW message or body]
On 11/28/2013 09:07 AM, Hui Zhu wrote:
> + if (have_target_target_side_commands)
This can now just be:
if (!VEC_empty (agent_expr_p, bp_tgt->tcommands))
OK with that change.
> + {
> + warning (_("\
> +Target doesn't support breakpoints that have target side commands."));
I was doing to suggest making this an error instead, that
insert_bp_location would print the error string, but that's
only true for hw breakpoints... insert_bp_location's error
handling is quite messy. For instance, if this breakpoint
is in a a shared library, this will disable the breakpoint,
even though the cause of the error is clearly not that the
shared library disappeared (i.e., not a memory error).
> + return -1;
> + }
--
Pedro Alves
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic