[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gdb-patches
Subject:    [patch][python] Fix python/14513
From:       pmuldoon () redhat ! com (Phil Muldoon)
Date:       2013-10-30 9:01:00
Message-ID: 5270CAC7.5050607 () redhat ! com
[Download RAW message or body]

On 21/10/13 22:58, Tom Tromey wrote:
>>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
> 
> Phil> I am not sure what the resolution is here.  At some point we have to
> Phil> decide whether we have anything valid to print.  We can hoist the
> Phil> fprint into both of these branches, but even in the "else" clause we
> Phil> have to check if we actually have anything as the fprint adds a
> Phil> newline to the set documentation:
> 
> Phil> fprintf_filtered (gdb_stdout, "%s\n", set_doc_string);
> 
> Phil> What are your thoughts on this?
> 
> I've been thinking about it more and I don't understand why we want to
> print anything in the "set" command.
> I think it's fine if we just don't call a method.
> What do you think of that?

I am fine with it, as long as you are.

Cheers,

Phil


[prev in list] [next in list] [prev in thread] [next in thread]