[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gdb-patches
Subject:    [PATCH]Add symbol whose field 'has_type' has been set to partial symbol table
From:       tromey () redhat ! com (Tom Tromey)
Date:       2013-10-29 18:34:00
Message-ID: 871u347wpy.fsf () fleche ! redhat ! com
[Download RAW message or body]

>>>>> ">" == hex  <heixia108@gmail.com> writes:

>> Thank you for the review. I have attached the test case.

The test case needs a ChangeLog entry.

I'd much prefer a test using the DWARF assembler than one using actual
assembly code.  There are other examples in gdb.dwarf2.  The reason to
prefer the DWARF assembler is that it is more portable.

>> # You should have received a copy of the GNU General Public License
>> # along with this program.  If not, see <http://www.gnu.org/licenses/>.
>> load_lib dwarf.exp

A blank line between the comments and the first line of code, please.

>> # Test DW_OP_stack_value and DW_OP_implicit_value.

This comment seems incorrect.

Tom


[prev in list] [next in list] [prev in thread] [next in thread]