[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gdb-patches
Subject:    [patch] Fixed occasional failure to load a custom shared  library
From:       lace () jankratochvil ! net (Jan Kratochvil)
Date:       2006-06-27 2:08:00
Message-ID: 20060627020830.GA10712 () host0 ! dyn ! jankratochvil ! net
[Download RAW message or body]

Hi Kevin,

On Tue, 27 Jun 2006 03:00:51 +0200, Kevin Buettner wrote:
...
> +  solib_absolute_prefix_is_empty = (!solib_absolute_prefix
> +                                    || !*solib_absolute_prefix);
> 
> I'd prefer to see this written as follows:
> 
> +  solib_absolute_prefix_is_empty = (solib_absolute_prefix == NULL
> +                                    || *solib_absolute_prefix == 0);

OK, I tried to copy the style but apparently not perfectly.

...
> (You forgot to include a ChangeLog entry though...)

2006-06-22  Jan Kratochvil  <lace@jankratochvil.net>

	* solib.c (solib_open): Fixed NULL vs. "" refusal to load inferior
	shared libraries.


> Are you able to commit this yourself or do you need someone to commit
> it for you?

I do not have the commit rights, please commit it for me.
So far I do not have FSF copyright assignment for gdb, if it would be required
for this trivia patch.



Thanks,
Jan


[prev in list] [next in list] [prev in thread] [next in thread]