[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gdb-patches
Subject:    [PATCH] Add fullname field for MI -break-info command
From:       ghost () cs ! msu ! su (Vladimir Prus)
Date:       2006-01-28 13:10:00
Message-ID: drfqem$kni$1 () sea ! gmane ! org
[Download RAW message or body]

Bob Rossi wrote:

> On Tue, Jan 24, 2006 at 07:32:15PM +0300, Vladimir Prus wrote:
>> 
>> Hello!
>> 
>> The attached patch adds the "fullname" field to the output of MI
>> -break-info command.
> 
> The patch seems good to me at first glance. However, you should also
> update the testsuite, and send in the patch for that as well.
> 
> Also, don't forget about the documentation.

Revised patch attached. I did verify that it causes no regressions for MI
tests.


Note, however, that I could not verify that it does not cause any
regressions globally, because something seems wrong with my configuration
or the test system. Sporadically, I get errors like this:

   Running ../.././gdb/testsuite/gdb.base/code-expr.exp ...
   gdb compile failed, spawn failed
   WARNING: Testcase compile failed, so all tests in this file will
   automatically fail.

   WARNING: remote_expect statement without a default case?!
   ERROR: couldn't
   load /space/p2/ghost/build/gdb/gdb/testsuite/gdb.base/cvexpr  
   into /space/p2/ghost/build/gdb/gdb/testsuite/../../gdb/gdb (end of file).
   FAIL: gdb.base/code-expr.exp: set print address off

Or messages like:

   gdb compile failed, gcc: fork: Resource temporarily unavailable

When running specific tests, the errors don't reproduce. Sometimes the
errors disappear by themself. So, it looks like testsystem needs more
resources (pids?) than is allowed by rlimit or something like that.


- Volodya



-------------- next part --------------
A non-text attachment was scrubbed...
Name: breakpoint_info_fullname.diff
Type: text/x-diff
Size: 18132 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20060128/8b00f2c1/attachment.bin>

[prev in list] [next in list] [prev in thread] [next in thread]