[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gdb-patches
Subject:    [commit] Add add_setshow_enum_cmd, use in mips
From:       cagney () gnu ! org (Andrew Cagney)
Date:       2004-10-31 23:01:00
Message-ID: 41856ECA.2060701 () gnu ! org
[Download RAW message or body]

Eli Zaretskii wrote:
>>Date: Sat, 30 Oct 2004 12:11:14 -0400
>>From: Andrew Cagney <cagney@gnu.org>
>>
>>Another cleanup.
>>
>>committed,
> 
> 
> FWIW, I don't see why is this a ``cleanup'', nor why should it be
> committed without going through an RFA.  You are introducing a new
> function, so at the very least the reasons for its introduction should
> have been explained and other maintainers should have been given an
> opportunity to suggest alternative designs.

The missing add_setshow_enum_cmd both goes with, and is consistent, with 
the existing add_setshow zinteger, boolean, auto_boolean, filename, 
string, uinteger command functions  I just plugged an obvious hole, and 
in the process fixed an i18n problem.

Andrew


[prev in list] [next in list] [prev in thread] [next in thread]