[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gdb-patches
Subject:    [RFA] minor glitch in output with confirm is off
From:       guitton () act-europe ! fr (Jerome Guitton)
Date:       2004-07-30 14:12:00
Message-ID: 20040730151229.GA4060 () act-europe ! fr
[Download RAW message or body]


On i686 linux:

(gdb) set confirm off
(gdb) add-symbol-file /usr/lib/libm.so
add symbol table from file "/usr/lib/libm.so" at
(no debugging symbols found)...(gdb)

Note that the minor glitch for the prompt... There is a missing line feed.
With my patch, I have this output:

(gdb) set confirm off
(gdb) add-symbol-file /usr/lib/libm.so
add symbol table from file "/usr/lib/libm.so" at
(no debugging symbols found)
(gdb) 

I almost committed it as obvious, but someone may prefer another output...
No regressions on i686 Linux. OK to apply?

2004-07-30  Jerome Guitton  <guitton@gnat.com>

	*  (symbol_file_add_with_addrs_or_offsets):  Make sure to print a
        line feed before the prompt.

Index: symfile.c
===================================================================
RCS file: /cvs/src/src/gdb/symfile.c,v
retrieving revision 1.136
diff -u -p -r1.136 symfile.c
--- symfile.c	30 Jul 2004 12:05:44 -0000	1.136
+++ symfile.c	30 Jul 2004 13:44:56 -0000
@@ -865,7 +865,11 @@ symbol_file_add_with_addrs_or_offsets (b
   if (!have_partial_symbols () && !have_full_symbols ())
     {
       wrap_here ("");
-      printf_unfiltered ("(no debugging symbols found)...");
+      printf_filtered ("(no debugging symbols found)");
+      if (from_tty || info_verbose)
+        printf_filtered ("...");
+      else
+        printf_filtered ("\n");
       wrap_here ("");
     }




[prev in list] [next in list] [prev in thread] [next in thread]