[prev in list] [next in list] [prev in thread] [next in thread]
List: gdb-patches
Subject: [RFA] string.h to gdb_string.h
From: dsmith () redhat ! com (David Smith)
Date: 2001-01-31 7:56:00
Message-ID: 3A78355B.1C821D66 () redhat ! com
[Download RAW message or body]
Using my new account, I've committed these changes.
Andrew Cagney wrote:
>
> Kevin Buettner wrote:
>
> > The only nit that I have with these changes is the use of the
> > comma after 2001 in the copyright notices. The prevailing
> > convention (if there is one) seems to be no comma after the
> > final year. Also, it is my understanding that year ranges
> > (e.g 1998-2000) are forbidden and that the years should be
> > spelled out explicitly. (You got this part right, but it
> > sure is tempting to use ranges.)
>
> I wouldn't be so worried. The TODO file already mentions that we need
> to clean up the copyright notices. We've even got patches to do this
> pending.
>
> > The ChangeLog entries probably ought to indicate the fact that
> > you updated the copyright notice in these files too.
>
> Um, some people do, some people don't. I'd be giving David credit for
> even remembering to update that copyright year.
>
> David, the changes are fine. Just watch out when you re-indent after
> appending that extra year. I'll follow up with an account.
>
> Andrew
--
David Smith
dsmith@redhat.com
Red Hat, Inc.
http://www.redhat.com
256.704.9222 (direct)
256.837.3839 (fax)
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic