[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gdb-cvs
Subject:    [binutils-gdb] Remove redundant variable from array_operation::evaluate
From:       Tom Tromey via Gdb-cvs <gdb-cvs () sourceware ! org>
Date:       2023-08-29 19:40:15
Message-ID: 20230829194015.2D91E3858D28 () sourceware ! org
[Download RAW message or body]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=21bdf43aa282d25ceb462099caee5693192a8fda

commit 21bdf43aa282d25ceb462099caee5693192a8fda
Author: Tom Tromey <tromey@adacore.com>
Date:   Mon Aug 28 12:43:35 2023 -0600

    Remove redundant variable from array_operation::evaluate
    
    In array_operation::evaluate, 'idx' and 'tem' are redundant in one
    branch.  This patch merges them, using the clearer name.
    
    Reviewed-by: John Baldwin <jhb@FreeBSD.org>
    Approved-By: Simon Marchi <simon.marchi@efficios.com>

Diff:
---
 gdb/eval.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/gdb/eval.c b/gdb/eval.c
index 6cf72545f62..710506ef778 100644
--- a/gdb/eval.c
+++ b/gdb/eval.c
@@ -2464,14 +2464,13 @@ array_operation::evaluate (struct type *expect_type,
       if (!get_discrete_bounds (element_type, &low_bound, &high_bound))
 	error (_("(power)set type with unknown size"));
       memset (valaddr, '\0', type->length ());
-      int idx = 0;
-      for (int tem = 0; tem < nargs; tem++)
+      for (int idx = 0; idx < nargs; idx++)
 	{
 	  LONGEST range_low, range_high;
 	  struct type *range_low_type, *range_high_type;
 	  struct value *elem_val;
 
-	  elem_val = in_args[idx++]->evaluate (element_type, exp, noside);
+	  elem_val = in_args[idx]->evaluate (element_type, exp, noside);
 	  range_low_type = range_high_type = elem_val->type ();
 	  range_low = range_high = value_as_long (elem_val);
[prev in list] [next in list] [prev in thread] [next in thread]