[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gdb-cvs
Subject:    [binutils-gdb] gdb/tui: Update help text for scroll commands
From:       Andrew Burgess <aburgess () sourceware ! org>
Date:       2020-01-31 0:41:59
Message-ID: 20200131004159.47450.qmail () sourceware ! org
[Download RAW message or body]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7a27a45bc66f38cbaee868092f0aaa55ef8d4564

commit 7a27a45bc66f38cbaee868092f0aaa55ef8d4564
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Date:   Fri Jan 24 14:18:56 2020 +0000

    gdb/tui: Update help text for scroll commands
    
    GDB has some commands ('+', '-', '<', and '>') for scrolling the SRC
    and ASM TUI windows from the CMD window, however the help text for
    these commands lists the arguments in the wrong order.
    
    This commit updates the help text to match how GDB actually works, and
    also extends the text to describe what the arguments mean, and what
    the defaults are.
    
    There should be no change in GDBs functionality after this commit.
    
    gdb/ChangeLog:
    
    	* tui/tui-win.c (_initialize_tui_win): Update help text for '+',
    	'-', '<', and '>' commands.
    
    Change-Id: Ib2624891de1f4ba983838822206304e4c3ed982e

Diff:
---
 gdb/ChangeLog     |  5 +++++
 gdb/tui/tui-win.c | 16 ++++++++++++----
 2 files changed, 17 insertions(+), 4 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 5352491..46acb63 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
+
+	* tui/tui-win.c (_initialize_tui_win): Update help text for '+',
+	'-', '<', and '>' commands.
+
 2020-01-29  Pedro Alves  <palves@redhat.com>
 	    Sergio Durigan Junior  <sergiodj@redhat.com>
 
diff --git a/gdb/tui/tui-win.c b/gdb/tui/tui-win.c
index 8b7c399..185ae26 100644
--- a/gdb/tui/tui-win.c
+++ b/gdb/tui/tui-win.c
@@ -1063,16 +1063,24 @@ FOCUS_USAGE
   set_cmd_completer (cmd, focus_completer);
   add_com ("+", class_tui, tui_scroll_forward_command, _("\
 Scroll window forward.\n\
-Usage: + [WIN] [N]"));
+Usage: + [N] [WIN]\n\
+Scroll window WIN N lines forwards.  Both WIN and N are optional, N\n\
+defaults to 1, and WIN defaults to the currently focused window."));
   add_com ("-", class_tui, tui_scroll_backward_command, _("\
 Scroll window backward.\n\
-Usage: - [WIN] [N]"));
+Usage: - [N] [WIN]\n\
+Scroll window WIN N lines backwards.  Both WIN and N are optional, N\n\
+defaults to 1, and WIN defaults to the currently focused window."));
   add_com ("<", class_tui, tui_scroll_left_command, _("\
 Scroll window text to the left.\n\
-Usage: < [WIN] [N]"));
+Usage: < [N] [WIN]\n\
+Scroll window WIN N characters left.  Both WIN and N are optional, N\n\
+defaults to 1, and WIN defaults to the currently focused window."));
   add_com (">", class_tui, tui_scroll_right_command, _("\
 Scroll window text to the right.\n\
-Usage: > [WIN] [N]"));
+Usage: > [N] [WIN]\n\
+Scroll window WIN N characters right.  Both WIN and N are optional, N\n\
+defaults to 1, and WIN defaults to the currently focused window."));
 
   /* Define the tui control variables.  */
   add_setshow_enum_cmd ("border-kind", no_class, tui_border_kind_enums,
[prev in list] [next in list] [prev in thread] [next in thread]