[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gdb-cvs
Subject:    [binutils-gdb] Remove regcache_cooked_read_value
From:       Simon Marchi <simark () sourceware ! org>
Date:       2018-05-30 18:58:05
Message-ID: 20180530185805.21525.qmail () sourceware ! org
[Download RAW message or body]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=46a45e9d5b067e484971e3972fa3eae0a224324f

commit 46a45e9d5b067e484971e3972fa3eae0a224324f
Author: Simon Marchi <simon.marchi@ericsson.com>
Date:   Wed May 30 14:54:42 2018 -0400

    Remove regcache_cooked_read_value
    
    Remove regcache_cooked_read_value, update callers to use
    readable_regcache::cooked_read_value.
    
    gdb/ChangeLog:
    
    	* regcache.h (regcache_cooked_read_value): Remove, update
    	callers to use readable_regcache::cooked_read_value.
    	* regcache.c (regcache_cooked_read_value): Remove.

Diff:
---
 gdb/ChangeLog        | 6 ++++++
 gdb/regcache.c       | 6 ------
 gdb/regcache.h       | 8 ++------
 gdb/sentinel-frame.c | 2 +-
 4 files changed, 9 insertions(+), 13 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 2d1dfb6..4e0b3a2 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,11 @@
 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
 
+	* regcache.h (regcache_cooked_read_value): Remove, update
+	callers to use readable_regcache::cooked_read_value.
+	* regcache.c (regcache_cooked_read_value): Remove.
+
+2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
+
 	* regcache.h (regcache_cooked_write): Remove, update callers to
 	use regcache::cooked_write.
 	* regcache.c (regcache_cooked_write): Remove.
diff --git a/gdb/regcache.c b/gdb/regcache.c
index 0e2d040..ee27f9d 100644
--- a/gdb/regcache.c
+++ b/gdb/regcache.c
@@ -639,12 +639,6 @@ readable_regcache::cooked_read (int regnum, gdb_byte *buf)
 }
 
 struct value *
-regcache_cooked_read_value (struct regcache *regcache, int regnum)
-{
-  return regcache->cooked_read_value (regnum);
-}
-
-struct value *
 readable_regcache::cooked_read_value (int regnum)
 {
   gdb_assert (regnum >= 0);
diff --git a/gdb/regcache.h b/gdb/regcache.h
index 4be1ae1..3497207 100644
--- a/gdb/regcache.h
+++ b/gdb/regcache.h
@@ -50,12 +50,6 @@ extern void regcache_raw_write_unsigned (struct regcache *regcache,
 extern LONGEST regcache_raw_get_signed (struct regcache *regcache,
 					int regnum);
 
-/* Read register REGNUM from REGCACHE and return a new value.  This
-   will call mark_value_bytes_unavailable as appropriate.  */
-
-struct value *regcache_cooked_read_value (struct regcache *regcache,
-					  int regnum);
-
 /* Read a register as a signed/unsigned quantity.  */
 extern enum register_status
   regcache_cooked_read_signed (struct regcache *regcache,
@@ -239,6 +233,8 @@ public:
   enum register_status cooked_read_part (int regnum, int offset, int len,
 					 gdb_byte *buf);
 
+  /* Read register REGNUM from the regcache and return a new value.  This
+     will call mark_value_bytes_unavailable as appropriate.  */
   struct value *cooked_read_value (int regnum);
 
 protected:
diff --git a/gdb/sentinel-frame.c b/gdb/sentinel-frame.c
index cbb4a09..282e29e 100644
--- a/gdb/sentinel-frame.c
+++ b/gdb/sentinel-frame.c
@@ -50,7 +50,7 @@ sentinel_frame_prev_register (struct frame_info *this_frame,
     = (struct frame_unwind_cache *) *this_prologue_cache;
   struct value *value;
 
-  value = regcache_cooked_read_value (cache->regcache, regnum);
+  value = cache->regcache->cooked_read_value (regnum);
   VALUE_NEXT_FRAME_ID (value) = sentinel_frame_id;
 
   return value;
[prev in list] [next in list] [prev in thread] [next in thread]