[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gdb-cvs
Subject:    src/gdb ChangeLog probe.c utils.c
From:       tromey () sourceware ! org
Date:       2013-05-30 17:39:34
Message-ID: 20130530173934.6231.qmail () sourceware ! org
[Download RAW message or body]

CVSROOT:	/cvs/src
Module name:	src
Changes by:	tromey@sourceware.org	2013-05-30 17:39:34

Modified files:
	gdb            : ChangeLog probe.c utils.c 

Log message:
	fix compile_rx_or_error
	
	compile_rx_or_error looks like a constructor, but it can return NULL.
	This patch changes it to remove the NULL return, making it work
	like any other cleanup constructor.
	
	This is a stylistic patch but I think it is also better for code to
	follow the normal conventions.
	
	* probe.c (collect_probes): Check arguments for NULL before
	calling compile_rx_or_error.
	* utils.c (compile_rx_or_error): Require 'rx' to be non-NULL.
	Remove NULL return.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.15672&r2=1.15673
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/probe.c.diff?cvsroot=src&r1=1.7&r2=1.8
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/utils.c.diff?cvsroot=src&r1=1.299&r2=1.300

[prev in list] [next in list] [prev in thread] [next in thread]