[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gdb
Subject:    Re: Solibs and objfile BFD ownership
From:       Paul Pluzhnikov <ppluzhnikov () google ! com>
Date:       2009-08-21 17:57:27
Message-ID: 8ac60eac0908211057n2acaa368tf20acbfad71a1ae () mail ! gmail ! com
[Download RAW message or body]

On Fri, Aug 21, 2009 at 10:29 AM, Tom Tromey<tromey@redhat.com> wrote:

> This is ok.   Thanks.

So committed.

> Paul> +   gdb_assert (*p_refcount == 1 || *p_refcount == 2);
>
> This assertion is a bit strange, but I suppose it is harmless.   If we
> ever want more sharing, we can always just remove it.   In the meantime I
> suppose it is checking that we don't over-share somehow.

The assertion was intended to catch somebody else in GDB using bfd_usrdata
for some other purpose (in a way I didn't find).

I think it's safe to leave it in for now.

Thanks,
-- 
Paul Pluzhnikov

[prev in list] [next in list] [prev in thread] [next in thread]