[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gdb
Subject:    Re: gdb/m2-typeprint.c does not compile with older gcc versions
From:       Jim Blandy <jimb () codesourcery ! com>
Date:       2006-05-28 22:22:02
Message-ID: vt27j4594dx.fsf () theseus ! home ! 
[Download RAW message or body]


Joel Brobecker <brobecker@adacore.com> writes:
> On Sat, May 27, 2006 at 01:12:28PM +0200, Peter Schauer wrote:
>> gdb/m2-typeprint.c does not compile with older gcc versions, e.g. gcc-2.95.2.
>> It is caused by declarations after code, which is a gcc extension AFAIK.
>> The gdb-6.5 branch is affected as well.
>> Here is a fix:
>
> Thanks Peter. To me, this is an obvious fix, so I checked it in for you
> in both head and 6.5 branch.
>
> 2006-05-27  Joel Brobecker  <brobecker@adacore.com>
>
>         From Peter Schauer <peterschauer@gmx.net>
>         * m2-typeprint.c (m2_record_fields): Move variable declarations
>         to the begining of the block.
>
> Tested by re-building GDB after patch.

For what it's worth, ISO C99 allows declarations after code.  I don't
know when it was introduced.  GDB is supposed to only require C90,
according to doc/gdbint.texinfo, so I agree the patch is right,
though.

[prev in list] [next in list] [prev in thread] [next in thread]