[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gcrypt-devel
Subject:    Re: [PATCH 2/2] aarch64/assembly: only use the lower 32 bit of an int parameters
From:       Martin_Storsjö <martin () martin ! st>
Date:       2018-03-28 19:39:42
Message-ID: alpine.DEB.2.20.1803282238430.20294 () cone ! martin ! st
[Download RAW message or body]

On Wed, 28 Mar 2018, Jussi Kivilinna wrote:

> * cipher/camellia-aarch64.S (_gcry_camellia_arm_encrypt_block)
> (__gcry_camellia_arm_decrypt_block): Make comment section about input
> registers match usage.
> * cipher/rijndael-armv8-aarch64-ce.S (_gcry_aes_ocb_auth_armv8_ce): Use
> 'w12' and 'w7' instead of 'x12' and 'x7'.
> (_gcry_aes_xts_enc_armv8_ce, _gcry_aes_xts_dec_armv8_ce): Fix function
> prototype in comments.
> * mpi/aarch64/mpih-add1.S: Use 32-bit registers for 32-bit mpi_size_t
> parameters.
> * mpi/aarch64/mpih-mul1.S: Ditto.
> * mpi/aarch64/mpih-mul2.S: Ditto.
> * mpi/aarch64/mpih-mul3.S: Ditto.
> * mpi/aarch64/mpih-sub1.S: Ditto.
> --
>
> Signed-off-by: Jussi Kivilinna <jussi.kivilinna@iki.fi>
> ---

Both patches look good to me, for what it's worth.

// Martin

_______________________________________________
Gcrypt-devel mailing list
Gcrypt-devel@gnupg.org
http://lists.gnupg.org/mailman/listinfo/gcrypt-devel
[prev in list] [next in list] [prev in thread] [next in thread]