[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gcrypt-devel
Subject:    Important fix for HMAC-SHA-384/512 - gcrypt-1.4.0 and earlier versions
From:       Daniel Black <dragonheart () gentoo ! org>
Date:       2008-11-06 8:12:29
Message-ID: 200811061912.32173.dragonheart () gentoo ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


Thanks for the notice Werner

slight difference in assert statements for 1.4.0 versions as attached

-- 
Daniel Black <dragonheart@gentoo.org>
Gentoo Foundation

["libgcrypt-1.4.0-HMAC-SHA-384-512.patch" (text/x-diff)]

--- cipher/md.c.orig	2007-08-14 02:46:51.000000000 +1000
+++ cipher/md.c	2008-11-06 19:05:37.000000000 +1100
@@ -791,7 +791,7 @@
   if ( !algo )
     return GPG_ERR_DIGEST_ALGO; /* i.e. no algo enabled */
 
-  if ( keylen > 64 ) 
+  if ( keylen > hd->ctx->macpads_Bsize ) 
     {
       helpkey = gcry_malloc_secure ( md_digest_length( algo ) );
       if ( !helpkey )
@@ -799,7 +799,7 @@
       gcry_md_hash_buffer ( algo, helpkey, key, keylen );
       key = helpkey;
       keylen = md_digest_length( algo );
-      assert ( keylen <= 64 );
+      assert ( keylen <= hd->ctx->macpads_Bsize );
     }
 
   memset ( hd->ctx->macpads, 0, 2*(hd->ctx->macpads_Bsize) );

["signature.asc" (application/pgp-signature)]

_______________________________________________
Gcrypt-devel mailing list
Gcrypt-devel@gnupg.org
http://lists.gnupg.org/mailman/listinfo/gcrypt-devel


[prev in list] [next in list] [prev in thread] [next in thread]