[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gcc-patches
Subject:    Re: [PATCH] [x86] Add detection of Icelake Client and Server
From:       Thiago Macieira <thiago.macieira () intel ! com>
Date:       2019-10-17 16:01:55
Message-ID: 3002633.CjXThnkejH () tjmaciei-mobl1
[Download RAW message or body]

On Wednesday, 16 October 2019 23:51:30 PDT Uros Bizjak wrote:
> > gcc/ChangeLog:
> >         * config/i386/driver-i386.c (host_detect_local_cpu): Handle
> >         
> >           icelake-client and icelake-server.
> >         
> >         * testsuite/gcc.target/i386/builtin_target.c 
(check_intel_cpu_model):
> >           Verify icelakes are detected correctly.
> > 
> > libgcc/ChangeLog:
> >         * config/i386/cpuinfo.c (get_intel_cpu): Handle icelake-client
> >         
> >           and icelake-server.
> 
> Please also state how you bootstrapped and tested the patch.

I didn't personally, but libgcc thus built was tested by a colleague who has 
access to engineering samples of some of those machines and they confirm 
icelake is properly detected. We didn't test gcc's -march=native detection.

The numbers come from the Linux kernel header:
https://github.com/torvalds/linux/blob/master/arch/x86/include/asm/intel-family.h#L77-L81
which in turn come from the Intel SDM, vol. 4,. The May 2019 edition has the 
most up-to-date values.

LLVM's compiler-rt equivalent:
https://github.com/llvm-mirror/compiler-rt/commit/
787bbab3e844b25bd3f8f282c6d3c8b3ad892fb4
https://github.com/llvm-mirror/compiler-rt/commit/
7a65a376f3ae2d770797eb87b7556a3689a6177a

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel System Software Products



[prev in list] [next in list] [prev in thread] [next in thread]