[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gcc-patches
Subject:    [Darwin, committed] Fix a couple of Wformat-diag build warnings.
From:       Iain Sandoe <iain () sandoe ! co ! uk>
Date:       2019-06-28 18:54:05
Message-ID: FB591655-984F-4EE2-897F-899C54666D2E () sandoe ! co ! uk
[Download RAW message or body]

As per $SUBJECT.
tested on a number of Darwin versions
applied to mainline
Iain


2019-06-28  Iain Sandoe  <iain@sandoe.co.uk>

	* config/darwin-c.c (pop_field_alignment): Quote #pragma options.
	* config/darwin-driver.c (darwin_default_min_version): Remove newline
	from warning.
	(darwin_driver_init): Likewise.

diff --git a/gcc/config/darwin-c.c b/gcc/config/darwin-c.c
index aa5d2f2..55b60da 100644
--- a/gcc/config/darwin-c.c
+++ b/gcc/config/darwin-c.c
@@ -79,7 +79,7 @@ pop_field_alignment (void)
       free (entry);
     }
   else
-    error ("too many #pragma options align=reset");
+    error ("too many %<#pragma options%> align=reset");
 }
 
 /* Handlers for Darwin-specific pragmas.  */
diff --git a/gcc/config/darwin-driver.c b/gcc/config/darwin-driver.c
index 3d85f29..49716fa 100644
--- a/gcc/config/darwin-driver.c
+++ b/gcc/config/darwin-driver.c
@@ -202,7 +202,7 @@ darwin_default_min_version (void)
       const char *checked = validate_macosx_version_min (new_flag);
       if (checked == NULL)
        {
-         warning (0, "couldn%'t understand version %s\n", new_flag);
+         warning (0, "couldn%'t understand version %s", new_flag);
          return NULL;
        }
       new_flag = xstrndup (checked, strlen (checked));
@@ -298,7 +298,7 @@ darwin_driver_init (unsigned int *decoded_options_count,
          vers_string =
            validate_macosx_version_min ((*decoded_options)[i].arg);
          if (vers_string == NULL)
-           warning (0, "%qs is not valid for %<mmacosx-version-min%>\n",
+           warning (0, "%qs is not valid for %<mmacosx-version-min%>",
                     (*decoded_options)[i].arg);
          else if (vers_string == (*decoded_options)[i].arg)
            vers_string = xstrndup ((*decoded_options)[i].arg, 32);

[prev in list] [next in list] [prev in thread] [next in thread]