[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gcc-patches
Subject:    Re: [C++ Patch] PR 84980 ("[concepts] ICE with missing typename in concept")
From:       Jason Merrill <jason () redhat ! com>
Date:       2018-08-31 20:35:16
Message-ID: CADzB+2nw=kSy6Fw08_oce1zg_eChebzJvz3buYdPQ_zO6E0Tag () mail ! gmail ! com
[Download RAW message or body]

OK.  And I'd say that this sort of error recovery qualifies as obvious.

Jason


On Fri, Aug 31, 2018 at 5:32 AM, Paolo Carlini <paolo.carlini@oracle.com> wrote:
> Hi,
>
> another straightforward ICE on invalid.  I spent however quite a bit of time
> on it, because I tried to catch the error_mark_node as early as possible,
> but that doesn't seem to work well error-recovery-wise: if, say, we catch it
> in deduce_constrained_parameter we end-up emitting a second redundant "‘C'
> is not a type" error message because we skip 'C' completely. Thus, at least
> for the time being, I propose to simply catch the problem in
> finish_shorthand_constraint (which likely avoids more ICEs already in
> Bugzilla...). Tested x86_64-linux.
>
> Thanks, Paolo.
>
> ////////////////////////
>
[prev in list] [next in list] [prev in thread] [next in thread]