[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gcc-patches
Subject:    Re: [PATCH, rs6000] Follow-on fix for PR target/80210: ICE in extract_insn
From:       Segher Boessenkool <segher () kernel ! crashing ! org>
Date:       2017-09-29 22:31:21
Message-ID: 20170929223120.GT8421 () gate ! crashing ! org
[Download RAW message or body]

Hi Peter,

On Thu, Sep 28, 2017 at 09:26:00PM -0500, Peter Bergner wrote:
> This patch fixes two new issues exposed (but not caused) by the original 
> test case added for PR80210 as well as a modified version of that test case.

[ .. snip ... ]

This all seems correct (but it is so complex that it is hard to be sure;
well it is _less_ complex now!)

> +	  /* PowerPC 64-bit LE requires at least ISA 2.07.  */
> +	  const char *default_cpu = ((!TARGET_POWERPC64)
> +				     ? "powerpc"
> +				     : ((BYTES_BIG_ENDIAN)
> +					? "powerpc64"
> +					: "powerpc64le"));

Please remove the parens around !TARGET_POWERPC64 and BYTES_BIG_ENDIAN
while you're at it (one of the copies you removed had that already :-) )

Looks great to me, please commit.  But hold off until Monday please, it
will interfere with testing otherwise.

Thanks!


Segher
[prev in list] [next in list] [prev in thread] [next in thread]