[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gcc-patches
Subject:    Re: [PATCH] Fix up handle_noipa_attribute
From:       Joseph Myers <joseph () codesourcery ! com>
Date:       2017-09-29 20:57:05
Message-ID: alpine.DEB.2.20.1709292056580.7702 () digraph ! polyomino ! org ! uk
[Download RAW message or body]

On Fri, 29 Sep 2017, Jakub Jelinek wrote:

> Hi!
> 
> I've noticed a bogus attribute (stack_protector) on a function with noipa
> attribute.
> 
> The reason seems to be misapplied patch of mine, the 4 lines below were
> actually from handle_stack_protect_attribute, but instead of moving those
> there, I'd like to remove them because they make no sense to me.
> When handle_*_attribute doesn't set *no_add_attrs, the attribute is added
> by the caller, so there is no point in it adding it by hand.
> 
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?

OK.

-- 
Joseph S. Myers
joseph@codesourcery.com
[prev in list] [next in list] [prev in thread] [next in thread]