[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gcc-patches
Subject:    Re: Patch I have Formatted in Git
From:       nick <xerofoify () gmail ! com>
Date:       2017-09-29 20:30:56
Message-ID: f6633dd4-5496-1e89-5f1c-18322c648182 () gmail ! com
[Download RAW message or body]



On 2017-09-29 04:25 PM, Joseph Myers wrote:
> On Fri, 29 Sep 2017, nick wrote:
> 
>> -  error_at (EXPR_LOCATION (call_expr), "cannot tail-call: %s", reason);
>> +  error_at (EXPR_LOCATION (call_expr), "cannot tail-call: %s", N_(reason));
> 
> This can't be right.  N_ only makes sense around a string literal (e.g. in 
> a constant initializer); it marks a string for extraction for translation, 
> but does not cause it to be translated at runtime.  You need _() to cause 
> the translation at runtime (and then make sure that every string constant 
> that can end up as a value of reason is surrounded by N_() - or just 
> surround the string constants directly by _() if there isn't a reason that 
> won't work).
> 
Exactly what was commented on my another developer I agree should be _(reason) 
as this will need to be used at runtime. I am just building and running
the tests for it now.

Thanks,
Nick
[prev in list] [next in list] [prev in thread] [next in thread]