[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gcc-patches
Subject:    Re: [Patch, fortran] PR35339 Optimize implied do loops in io statements
From:       Bernhard Reutner-Fischer <rep.dot.nop () gmail ! com>
Date:       2017-05-31 23:15:01
Message-ID: CAC1BbcQhsfijA+pUaHUGgM1UfLhedUQnuPtituN4vZ2FnnZ6ZQ () mail ! gmail ! com
[Download RAW message or body]

On 31 May 2017 at 21:03, Nicolas Koenig <koenigni@student.ethz.ch> wrote:
> Hello Dominique,
>
> attached is the next try, this time without stupidities (I hope). Both test
> cases you posted don't ICE anymore.
>
> Ok for trunk?

Please check contrib/check_GNU_style.sh /tmp/p8.diff
and let me point you to contrib/vimrc

Furthermore:

+/* Recursivly traverse the block of a WRITE or READ statement, and, can it be
+   optimized, do so. It optimizes it by replacing do loops with their analog
+   array slices. For example:

s/Recursivly/Recursively

Maybe:
Recursively traverse the block of a WRITE or READ statement and maybe
optimize it by ...

+  if (curr->expr1->shape)
+    {
+      new_e->shape = gfc_get_shape(new_e->rank);
+    }
+
+
No curly braces around single stmt if-bodies.
Excess vertical space.

+  if (!(*code)->block || ((*code)->block->op != EXEC_WRITE
+                          && (*code)->block->op != EXEC_READ))

break line on ||
  if (!(*code)->block
      || ((*code)->block->op != EXEC_WRITE
          && (*code)->block->op != EXEC_READ))

thanks,
[prev in list] [next in list] [prev in thread] [next in thread]