[prev in list] [next in list] [prev in thread] [next in thread]
List: gcc-patches
Subject: Re: [PATCH MIPS RFA] Regression cleanup for nan2008 toolchain
From: Richard Sandiford <richard.sandiford () arm ! com>
Date: 2015-01-31 11:50:16
Message-ID: 87vbjnnp8n.fsf () e105548-lin ! cambridge ! arm ! com
[Download RAW message or body]
Robert Suchanek <Robert.Suchanek@imgtec.com> writes:
> diff --git a/gcc/testsuite/gcc.target/mips/loongson-simd.c \
> b/gcc/testsuite/gcc.target/mips/loongson-simd.c index 160da6b..949632e 100644
> --- a/gcc/testsuite/gcc.target/mips/loongson-simd.c
> +++ b/gcc/testsuite/gcc.target/mips/loongson-simd.c
> @@ -22,6 +22,7 @@ along with GCC; see the file COPYING3. If not see
> /* loongson.h does not handle or check for MIPS16ness or
> microMIPSness. There doesn't seem any good reason for it to, given
> that the Loongson processors do not support either. */
> +/* { dg-require-effective-target mips_nanlegacy } */
> /* { dg-options "isa=loongson -mhard-float -mno-micromips -mno-mips16 \
> -flax-vector-conversions" } */
Nit, but this splits the dg-options from the comment that explains
the options.
Please could you add a comment explaining that the mips_nanlegacy is there
because of the #include of system headers that might not compile with
-mnan=legacy? I agree that that's a good reason, but it's not obvious
without a comment. (And without a comment this could start a precendent
of things being skipped in cases where the mips.exp options machinery
could be updated instead.)
Thanks,
Richard
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic