[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gcc-patches
Subject:    Re: [AArch64/AArch64-4.7] Fix warning - aarch64_mangle_type has no prototype.
From:       Marcus Shawcroft <marcus.shawcroft () gmail ! com>
Date:       2013-02-28 16:23:59
Message-ID: CAFqB+PxtLc_cj5Y_25v9GaRrAyuJAt9C61ieOJMt5CxU1NNskw () mail ! gmail ! com
[Download RAW message or body]

OK

On 28 February 2013 09:36, James Greenhalgh <james.greenhalgh@arm.com> wrot=
e:
>
> Hi,
>
> aarch64_mangle_type has no prototype, but it doesn't need one as
> it should be declared static.
>
> This patch fixes the warning:
>
> config/aarch64/aarch64.c:5974:1: warning: no previous prototype for =91aa=
rch64_mangle_type=92 [-Wmissing-prototypes]
>
> Which is hidden when building with g++, but looks like:
>
> config/aarch64/aarch64:5990:1: warning: no previous declaration for =91co=
nst char* aarch64_mangle_type=92 [-Wmissing-declarations]
>
> On Trunk.
>
> Regression tested on aarch64-none-elf with no regressions.
>
> OK for trunk and aarch64-4.7-branch?
>
> Thanks,
> James Greenhalgh
>
> ---
> gcc/
>
> 2013-02-28  James Greenhalgh  <james.greenhalgh@arm.com>
>
>         * config/aarch64/aarch64.c (aarch64_mangle_type): Make static.
[prev in list] [next in list] [prev in thread] [next in thread]