[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gcc-patches
Subject:    Re: [PING][Patch,ARM] unwind in epilogue ignore dwarf info
From:       Ramana Radhakrishnan <ramrad01 () arm ! com>
Date:       2012-08-31 16:17:16
Message-ID: 5040E38C.2050902 () arm ! com
[Download RAW message or body]

On 08/31/12 13:50, Greta Yorsh wrote:
> Ping
> http://gcc.gnu.org/ml/gcc-patches/2012-07/msg01025.html
>
> ________________________________________
> From: Greta Yorsh [Greta.Yorsh@arm.com]
> Sent: Friday, July 20, 2012 7:28 PM
> To: GCC Patches
> Cc: Richard Earnshaw; Ramana Radhakrishnan
> Subject: [Patch,ARM] unwind in epilogue ignore dwarf info
>
> The final pass of gcc uses dwarf information to generate unwind tables and
> directives (e.g., with command line option -fexceptions). Dwarf information
> generated for epilogues should be ignored when generating unwind info,
> because the ARM ABI only allows unwind at procedure boundaries. This patch
> adds a flag unwind_in_epilogue for it. It wasn't needed in the past, because
> there was no dwarf info generated for epilogues, but recent patches for
> epilogue generation in RTL added it.


Hmmm, slightly uneasy about this patch.

Is there a chance that for a particular function 
arm_unwind_function_begin_epilogue gets called but 
arm_asm_emit_except_personality is not for some reason ? I'm worried a 
bit about stale values of unwind_epilogue I suppose across functions.

I'd prefer this to be in machine_function in arm.h .	


regards,
Ramana


[prev in list] [next in list] [prev in thread] [next in thread]