[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gcc-patches
Subject:    Re: [PATCH][RFC] Add a subset of -Warray-bounds warnings to C/C++  front ends
From:       Simon Baldwin <simonb () google ! com>
Date:       2008-05-02 20:03:19
Message-ID: 481B7387.9080602 () google ! com
[Download RAW message or body]

H.J. Lu wrote:
> On Fri, May 2, 2008 at 12:53 PM, Andrew Pinski <pinskia@gmail.com> wrote:
>   
>> On Fri, May 2, 2008 at 9:34 AM, Mark Mitchell <mark@codesourcery.com> wrote:
>>  > Simon Baldwin wrote:
>>  >
>>  >
>>  > > I think the wisest course for now is to roll back this change until I have
>>  > a better understanding of the issues.
>>  > >
>>  >
>>  >  If you want to roll back, that's fine.  You can do that without any further
>>  > approval.
>>
>>  x86-darwin is also broken with the following warning:
>>  /home/regress/tbox/svn-gcc/gcc/config/i386/i386.c:20877: error: array
>>
>> subscript is above array bounds
>>
>>  which is a false warning.
>>  We have:
>>  mode0 = insn_data[icode].operand[0].mode;
>>
>>  where insn_data is defined as:
>>  extern const struct insn_data insn_data[];
>>
>>  operand is a pointer so that is not an issue.
>>
>>     
>
> May I suggest to revert it now and use a branch to implement it
> properly before merging it with trunk? I can prepare a patch in half
> an hour.
>   

I've just this minute committed the rollback -- revision 134889.  
Testing did not complete as quick as I'd hoped; sorry for the delay.

Thanks.  --S

[prev in list] [next in list] [prev in thread] [next in thread]