[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gcc-patches
Subject:    Re: [PATCH][RFC] Add a subset of -Warray-bounds warnings to C/C++   front ends
From:       Simon Baldwin <simonb () google ! com>
Date:       2008-05-01 19:07:02
Message-ID: 481A14D6.8040002 () google ! com
[Download RAW message or body]

Thanks all.  Committed, with suggested doc/invoke.texi change, as 
revision 134865.


Mark Mitchell wrote:
> Simon Baldwin wrote:
>> Thanks to a well targeted pointer from Tom Tromey, I've now added the 
>> extra logic to suppress warnings about "sizeof(a[-1])" in the C and 
>> C++ frontends.  Attached is the revised version.
>
> Thanks for following up.  I think this is a worthwhile patch.
>
>> +This option performs a subset of checks in unoptimized compilations, 
>> and
>> +stricter checking when @option{-ftree-vrp} is active
>>  (default for -O2 and above). 
>
> I think "stricter" could be made more explicit.  How about something 
> like:
>
> This option detects some cases of out-of-bounds accesses in 
> unoptimized compilations.  More cases are detected when 
> @option{-ftree-vrp} is enabled.  (The @option{-ftree-vrp} option is 
> enabled automatically when compiling with @option{-O2} or higher 
> optimization options.)
>
> Joseph, do you have any comments on the C changes?  Simon, if you do 
> not hear otherwise from Joseph within 72 hours, this patch is OK.
>
> Thanks,
>

[prev in list] [next in list] [prev in thread] [next in thread]