[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gcc-patches
Subject:    Re: [PATCH] Fix canonical types w/ transparent unions (4.3 regression,  PR c++/35315)
From:       Mark Mitchell <mark () codesourcery ! com>
Date:       2008-02-29 19:42:57
Message-ID: 47C86041.9000708 () codesourcery ! com
[Download RAW message or body]

Doug Gregor wrote:
> Here's a slightly improved patch, which moves the canonical-types fix
> into build_duplicate_type. I'll commit to mainline tomorrow if there
> are no objections. However, I'm pinging Mark and Jakub to ask whether
> this is patch should also go into 4.3. I believe the answer is "no",
> but here's some reasoning.

I agree it's not a severe problem, but it is going to lead to problems 
somewhere, for someone, and it's a simple patch so let's put it in on 
the 4.3 branch as well.

> 2008-02-26  Douglas Gregor  <doug.gregor@gmail.com>
> 
> 	PR c++/35315
> 	* tree-inline.c (build_duplicate_type): When we make a
> 	duplicate type, make it unique in the canonical types system.
> 
> 2008-02-26  Douglas Gregor  <doug.gregor@gmail.com>
> 
> 	PR c++/35315
> 	* g++.dg/ext/attrib32.C: Add another test case.

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713
[prev in list] [next in list] [prev in thread] [next in thread]