[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gcc-patches
Subject:    Re: new argument macro: INITIAL_ARGS_SIZE
From:       Richard Henderson <rth () redhat ! com>
Date:       2002-02-28 22:57:13
[Download RAW message or body]

On Fri, Mar 01, 2002 at 09:18:08AM +1100, Aldy Hernandez wrote:
> ! 	save_area = plus_constant (virtual_stack_vars_rtx,
> ! 				   - RS6000_VARARGS_SIZE);
> ! 	save_area
> ! 	  = plus_constant (virtual_stack_vars_rtx,
> ! 			   - RS6000_VARARGS_SIZE
> ! 			   + INITIAL_ARGS_SIZE (current_function_decl));

We're getting close.

I didn't notice this one last time.  This is wrong, I think.
virtual_stack_vars_rtx is frame_pointer plus STARTING_FRAME_OFFSET,
which should already include INITIAL_ARGS_SIZE.

Also, STARTING_FRAME_OFFSET should be using STACK_POINTER_OFFSET
instead of RS6000_SAVE_AREA.  As it is you're counting that space
twice: once from current_function_outgoing_args_size, since that
includes INITIAL_ARGS_SIZE, and once from the explicit reference
to RS6000_SAVE_AREA there in the macro.


r~
[prev in list] [next in list] [prev in thread] [next in thread]