[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gcc-fortran
Subject:    Re: [PATCH] Fortran: fix simplification of INDEX(str1,str2) [PR105691]
From:       Harald Anlauf via Fortran <fortran () gcc ! gnu ! org>
Date:       2022-06-26 20:22:56
Message-ID: e3c8caee-55ec-1fbd-b1a5-858064fe17b5 () gmx ! de
[Download RAW message or body]

Hi Thomas,

thanks for the reviews!

Harald

Am 26.06.22 um 11:14 schrieb Thomas Koenig via Fortran:
> Hello Harald,
> 
>> compile time simplification of INDEX(str1,str2,back=.true.) gave wrong
>> results.  Looking at gfc_simplify_index, this appeared to be close to
>> a complete mess, while the runtime library code - which was developed
>> later - was a relief.
>>
>> The solution is to use the runtime library code as template to fix this.
>> I took the opportunity to change string index and length variables
>> in gfc_simplify_index to HOST_WIDE_INT.
>>
>> Regtested on x86_64-pc-linux-gnu.  OK for mainline?
>>
>> As this is a wrong-code issue, would this qualify for backports to
>> open branches?
> 
> OK for both.
> 
> Thanks for the patch!
> 
> 
> Best regards
> 
>      Thomas
> 


[prev in list] [next in list] [prev in thread] [next in thread]