[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gcc-fortran
Subject:    Re: [Patch] Fortran: Add 'device_type' clause to OpenMP's declare target
From:       Tobias Burnus <tobias () codesourcery ! com>
Date:       2020-08-26 7:33:48
Message-ID: c50704f5-3e5f-2a50-39e8-fad8c90404a8 () codesourcery ! com
[Download RAW message or body]

Thanks. I have now committed it as
r11-2858-gd58e7173ef964ddac3ab3ad8cc97de8f9f3b32ee

Tobias

On 8/20/20 6:10 PM, Andre Vehreschild wrote:
> Hi Tobias,
>
> to me this looks OK now.
>
> Regards,
>       Andre
>
> On Thu, 20 Aug 2020 11:51:50 +0200
> Tobias Burnus <tobias@codesourcery.com> wrote:
>
>> Updated patch – taking Andre's suggestions into account +
>> extending the testcase, which now catches the previous (NO)HOST
>> module issue.
>>
>> OK?
>>
>> Tobias
>>
>> On 8/19/20 2:51 PM, Tobias Burnus wrote:
>>> Am 18.08.20 um 19:33 schrieb Andre Vehreschild:
>>>> +    case OMP_DEVICE_TYPE_HOST:
>>>> +      MIO_NAME (ab_attribute) (AB_OMP_DEVICE_TYPE_NOHOST, attr_bits);
>>>> Why also NOHOST here?
>>> Copy and paste error.
>> ...
>>>> +      tree clauses = NULL_TREE;
>>>> Would you mind using "omp_clauses" or the like here?
>> Done now.
>> -----------------
>> Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany
>> Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung,
>> Alexander Walter
>
-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany
Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter
[prev in list] [next in list] [prev in thread] [next in thread]