[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gcc-fortran
Subject:    Re: [PATCH] (Partial) Implementation of simplificaiton of CSHIFT
From:       Steve Kargl <sgk () troutmask ! apl ! washington ! edu>
Date:       2015-12-31 16:13:34
Message-ID: 20151231161334.GA11994 () troutmask ! apl ! washington ! edu
[Download RAW message or body]

On Thu, Dec 31, 2015 at 09:57:10PM +0800, Gerald Pfeifer wrote:
> On Sat, 21 Nov 2015, Steve Kargl wrote:
> >  2015-11-21  Steven G. Kargl  <kargl@gcc.gnu.org>
> >  
> > 	* simplify.c (gfc_simplify_cshift): Work around bootstrap issues
> > 	due to inappropriate warning options. 
> 
> > Index: simplify.c
> > ===================================================================
> > +      /* GCC bootstrap is too stupid to realize that the above code for dm
> > +	 is correct.  First, dim can be specified for a rank 1 array.  It is
> > +	 not needed in this nor used here.  Second, the code is simply waiting
> > +	 for someone to implement rank > 1 simplification.   For now, add a
> > +	 pessimization to the code that has a zero valid reason to be here.  */
> > +      if (dm > array->rank)
> > +	gcc_unreachable ();
> 
> I'm not sure this comment is appropriate as is.  At a minimum, it
> should list the version of GCC this was introduced for/with.  So,
> something like
> 

I have no intention to change the comment.

-- 
Steve
[prev in list] [next in list] [prev in thread] [next in thread]