[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gcc-fortran
Subject:    Re: [Patch, fortran] PR65792 - allocation of scalar elemental function with structure constructor fa
From:       Paul Richard Thomas <paul.richard.thomas () gmail ! com>
Date:       2015-04-27 20:42:39
Message-ID: CAGkQGiK0puVoALMW36TzdoWPE=zw8fNOEu2uzeAEO6CJe2SUoA () mail ! gmail ! com
[Download RAW message or body]

Dear Steve,

Thanks for the review. I THINK that I know what I meant in the comment
:-) I will commit tomorrow night.

Cheers

Paul

On 26 April 2015 at 20:53, Steve Kargl <sgk@troutmask.apl.washington.edu> wrote:
> On Sun, Apr 26, 2015 at 08:35:06PM +0200, Paul Richard Thomas wrote:
>>
>> --- 7062,7091 ----
>>       {
>>         if (expr->expr_type != EXPR_STRUCTURE)
>>       {
>> +       tree dealloc = NULL_TREE;
>>         gfc_init_se (&se, NULL);
>>         gfc_conv_expr (&se, expr);
>>         gfc_add_block_to_block (&block, &se.pre);
>> +       /* Prevent repeat evaluations in gfc_copy_alloc_comp by fixing the
>> +          expression in  a temporary variable and deallocate is allocatable
>> +          components the copy to the result.  */
>
> Can you take a second shot at this comment?  The "and ..." portions
> seems to be a little muddled.
>
> OK with after comment fix.
>
> --
> Steve



-- 
Outside of a dog, a book is a man's best friend. Inside of a dog it's
too dark to read.

Groucho Marx
[prev in list] [next in list] [prev in thread] [next in thread]