[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gcc-fortran
Subject:    Re: [Patch, fortran] PR 59599 ICE on intrinsic ichar
From:       Mikael Morin <mikael.morin () sfr ! fr>
Date:       2014-02-15 11:19:02
Message-ID: 52FF4D26.2090503 () sfr ! fr
[Download RAW message or body]

Le 15/02/2014 11:04, Richard Biener a écrit :
> On Fri, 14 Feb 2014, Mikael Morin wrote:
> 
>> Hello,
>>
>> this bug is not a regression, but the patch shouldn't wreck the compiler
>> too much on the other hand.
>> The problem is a wrong number of arguments while generating code for the
>> ichar intrinsic.  The correct number is 2 without the kind argument and
>> 3 with it.
>> The attached patch uses the gfc_intrinsic_argument_list_length function
>> like it's done for other intrinsics.
>>
>> Regression tested on x86_64-unknown-linux-gnu. OK for trunk/4.8/4.7?
> 
> Generally wrong-code non-regression fixes for Fortran are fine
> if Fortran maintainers think so.
> 
Technically it's an ICE, not a wrong-code; but I bet it would be a
wrong-code if the scalarizer didn't notice a problem.
I'll proceed with the committal. Thanks for the review(s).

Mikael
[prev in list] [next in list] [prev in thread] [next in thread]