[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gcc-fortran
Subject:    Re: [Patch, Fortran] FINAL (prep patches 2/5): Add internal STRIDE intrinsicg
From:       Steve Kargl <sgk () troutmask ! apl ! washington ! edu>
Date:       2012-12-31 19:38:28
Message-ID: 20121231193828.GA12118 () troutmask ! apl ! washington ! edu
[Download RAW message or body]

On Mon, Dec 31, 2012 at 08:19:49PM +0100, Tobias Burnus wrote:
> Hi Steve,
> 
> Steve Kargl:
> > On Mon, Dec 31, 2012 at 01:17:04PM +0100, Tobias Burnus wrote:
> >> This new intrinsic is only internally available and will be used by the
> >> finalization wrapper to handle noncontiguous arrays.
> > What is the plan for when J3 decides to add a
> > STRIDE intrinsic
> 
> Well, we then add it. As written, this intrinsic is *only* *internally* 
> available.
> 
> Actually, I do hope that J3 will add a better access to Fortran's array 
> descriptor. Currently, one can do a lot of manipulations from C (since 
> ISO/IEC TS 29113:2012) but not from Fortran. The better access from 
> Fortran also matches the wish of the UK's BSI Fortran Panel: 
> ftp://ftp.nag.co.uk/sc22wg5/N1901-N1950/N1923.pdf (4th non-indent 
> paragraph).
> 
> > At a minimum, please consider adding a leading underscore to the function.
> 
> If you had read the patch carefully, you had seen that the intrinsic is 
> defined as GFC_PREFIX ("stride"), which expands on most systems to 
> "_F._stride".
> 

Ah, I did miss the GFC_PREFIX declaration.  I was going off
your (mis)description of what you were adding to the list
of intrinsics.  Namely, you stated you were adding a STRIDE
intrinsic when in fact you are adding a GFC_PREFIX("stride")
intrinsic.

-- 
Steve
[prev in list] [next in list] [prev in thread] [next in thread]