[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gcc-fortran
Subject:    Re: [Patch, Fortran] PR52029/52013 - small OOP fixes (pure _copy, CAF fix)
From:       Paul Richard Thomas <paul.richard.thomas () gmail ! com>
Date:       2012-01-31 12:44:30
Message-ID: CAGkQGiK0zhJDRF3p_LvPqt_O=y_bbksXpN9rOc8XVxS-yRMgYw () mail ! gmail ! com
[Download RAW message or body]

Dear Tobias,

OK for trunk on both.

Thanks

Paul

On Mon, Jan 30, 2012 at 9:54 PM, Tobias Burnus <burnus@net-b.de> wrote:
> First, I am looking for someone to review my patch at
> http://gcc.gnu.org/ml/fortran/2012-01/msg00241.html
>
> This patch contains two patches:
>
> a) Marking the polymorphic _copy function as pure. First, it helps with code
> generation as the function is actually pure. Secondly, if one defines the
> derived type in a PURE function, one currently gets an error as the impure
> function _copy is called.
>
> b) We need to build a different class container type for coarrays - the
> attached test case is an example why (missing diagnosis as the container
> didn't have the coarray attribute). At the same time, I fixes the hash
> function criterion. Since the polymorphic array patch, one some long module
> + type names were cropped instead of triggering the hash mechanism,
> increasing the chance for name collision.
>
> Build and regtested on x86-64-linux.
> OK for the trunk?
>
> Tobias



-- 
The knack of flying is learning how to throw yourself at the ground and miss.
       --Hitchhikers Guide to the Galaxy
[prev in list] [next in list] [prev in thread] [next in thread]