[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gcc-fortran
Subject:    Re: [PATCH, Fortran] PING: Extend gfc_code internal documentation
From:       Daniel Kraft <domob1812 () gmail ! com>
Date:       2008-06-27 14:25:02
Message-ID: 4864F83E.4060008 () domob ! eu
[Download RAW message or body]

Tobias Burnus wrote:
> Hi Daniel,
> 
> Daniel Kraft wrote:
>> Are there any comments on that one?
> Looks OK. Thanks for your fantastic work. Sorry that we don't do timely 

Thanks, I'll address the comments and check in tomorrow evening as written.

> +This statement-block will be represented in the internal gfortran tree 
> like
> +this, were the horizontal link-chains are those induced by the @code{next}
> 
> Instead of "like this" I'd use "as follows".

Sounds good.

> +next @code{ELSEIF} or @code{ELSE} block if there's a chain of them.
> +
> +@subsection Loops
> 
> 
> I'd add another empty line to make it easier to find the @subsections.

Ok.

> +@code{op} member set to @code{EXEC_IF}.  This structure's @code{block}
> +member must point to another @code{gfc_code} node being the header of the
> +if-block.  This header's @code{op} member must be set to 
> @code{EXEC_IF}, too,
> 
> Instead of "being", I'd use "which is".

Will do "that is" as suggested by Dominique.

Cheers,
Daniel, who will start with gfc_expr hopefully soon...

-- 
Done:     Bar-Sam-Val-Wiz, Dwa-Elf-Hum-Orc, Cha-Law, Fem-Mal
Underway: Ran-Gno-Neu-Fem
To go:    Arc-Cav-Hea-Kni-Mon-Pri-Rog-Tou

[prev in list] [next in list] [prev in thread] [next in thread]