[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gcc-fortran
Subject:    Re: [patch] Implement sizeof intrinsic, a minor cleanups to trans-intrinsic.c
From:       Paul Thomas <paulthomas2 () wanadoo ! fr>
Date:       2007-05-29 4:42:43
Message-ID: 465BAF43.20409 () wanadoo ! fr
[Download RAW message or body]

Tobi,
>
>
> the attached patch implements the SIZEOF intrinsic.  Since the code 
> for determining the length is copied from the code for TRANSFER, I had 
> a chance to look at that as well and noticed the complete lack of 
> constant-folding in it as well as a redundant initialization, which I 
> chose to fix.  The code could also be
Ooops to the initialization.  OK for the constant folding.
> somewhat simplified, as I did in the version for SIZEOF, but for fear 
> of introducing bugs, I didn't touch it.  I tried to avoid the 
> redundancy between the two size-determination codes by merging them, 
> but failed at doing so: I would have had to walk the expression twice 
> in gfc_conv_intrinsic_array_transfer, which wouldn't have left me with 
> much saved code.
:-(
>
> The patch comes with a new testcase which exercises the stuff that 
> should be platform independent.  Built and tested on i386-darwin.  I 
> also checked make pdf.  Ok?
>
OK for trunk.

Thanks

Paul


[prev in list] [next in list] [prev in thread] [next in thread]