[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gcc-fortran
Subject:    Re: namelist upgrade
From:       Tobias_Schlüter <tobias.schlueter () physik ! uni-muenchen ! de>
Date:       2005-03-31 22:17:25
Message-ID: 424C76F5.2080706 () physik ! uni-muenchen ! de
[Download RAW message or body]

THOMAS Paul Richard wrote:
> These patches extend the functionality of namelist io to within a few
> whiskers of the f95 and f2k standards.  They also cure PRs 18392, 19467,
> 17285, 18122, [18591], 18210, 12884, 19657, 17472, [18396], [18209] and, for
> the main part, 18879.

Very cool!  Do you know what's missing for full support?

> Tobi and Bud have expressed an interest in undertaking the review.  I would
> be interested in feedback from anybody else that has the time to cast an eye
> over this upgrade and to give it a try.

I can make no promises that I'll get there timely, I'll try to have an
in-depth look at it next week.

> I looked into serving this lot in easy mouthfulls but came to the conclusion
> that it would be more extra work than is warranted.  However, in order to
> make the reviewer's task easier, I have written a descriptive note, to be
> found in .rtl and .htm formats, in the attached zip file, desc.zip.

This didn't make it through to the list.  I think both .zip files and parts
with Content-type: text/html are not allowed.  Maybe you can put it on the web
somewhere, or incorporate the information contained therein into source-level
comments.

> Somewhat ill-advisedly, I applied a "retabber" (written with gfortran, of
> course!) to the patches.  This has obscured the patches a bit, for which I
> apologise.  If these bits are intolerable, I can provide patches with
> white-space ignored.

Please do this, I had a quick look over the diffs, and it looked like a huge
number of hunks are affected by this.

> 2005-03-31 Paul Thomas <paulthomas2@wanadoo.fr>
> 
> 	PRs 18392, 17285, 18122, 18210, 12884 & 18879
> 	* io/io.h, transfer.c, lock.c, list_read.c, write.c: namelist
> upgrades.
> 
> 	PRs 19467, 19657 & 17472
> 	* fortran/trans-io.c: namelist upgrades.

This is definitely not a sufficient ChangeLog, but I understand you expect the
patch to go through a few revisions.

- Tobi

[prev in list] [next in list] [prev in thread] [next in thread]