[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gcc-bugs
Subject:    [Bug tree-optimization/38156] gcc.dg/tree-ssa/update-unswitch-1.c fails when compiled with -ftree-pa
From:       "reichelt at gcc dot gnu dot org" <gcc-bugzilla () gcc ! gnu ! org>
Date:       2008-12-31 21:35:15
Message-ID: 20081231213515.30875.qmail () sourceware ! org
[Download RAW message or body]



------- Comment #4 from reichelt at gcc dot gnu dot org  2008-12-31 21:35 -------
Razya, Zdenek,

the patch committed does something different than the patch approved.
Here's part of what was committed:

> !  if (htab_elements (name_copies) == 0 && reduction_list == 0)

And the matching part of what was approved:
> !  if (htab_elements (name_copies) == 0 
> !      && (!reduction_list || htab_elements (reduction_list) == 0))
>
> reduction_list is never NULL, so it suffices to check htab_elements
> (reduction_list) == 0.

Could you please have a look?

Btw, the patch is missing a testcase.

And by the way, can this PR be closed or is a backport to 4.3 (where the crash
also occurs) for this simple fix intended?


-- 

reichelt at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |reichelt at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |monitored
   Last reconfirmed|0000-00-00 00:00:00         |2008-12-31 21:35:15
               date|                            |
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38156

[prev in list] [next in list] [prev in thread] [next in thread]